Triangulation_3.h uses deprecated std::random_shuffle

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Triangulation_3.h uses deprecated std::random_shuffle

Adam Getchell
The std::random_shuffle was deprecated in C++14 and eliminated in C++17 in favor of std::shuffle.


Triangulation_3.h (among many others) uses std::random_shuffle, so compilation errors occur with C++17.


As far as I can tell, this is still true of the most recent code, e.g. 4.12-beta1.

This looks fixable with ClangTidy, e.g.


Would a pull request to apply these changes be accepted?

Thanks,

Adam